From: Julia Lawall <julia.lawall@lip6.fr>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "rpeterso@redhat.com" <rpeterso@redhat.com>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"esc.storagedev@microsemi.com" <esc.storagedev@microsemi.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"dev@openvswitch.org" <dev@openvswitch.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"dccp@vger.kernel.org" <dccp@vger.kernel.org>,
"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 2 Jan 2018 16:16:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801021615510.23552@hadrien> (raw)
In-Reply-To: <1514905900.4242.4.camel@wdc.com>
On Tue, 2 Jan 2018, Bart Van Assche wrote:
> On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote:
> > On Tue, 2 Jan 2018, Bob Peterson wrote:
> > > ----- Original Message -----
> > > > ----- Original Message -----
> > > >
> > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
> > > and I don't like the thought of re-combining them all.
> >
> > Actually, the point of the patch was to remove the unnecessary \n at the
> > end of the string, because log_print will add another one. If you prefer
> > to keep the string broken up, I can resend the patch in that form, but
> > without the unnecessary \n.
>
> Please combine any user-visible strings into a single line for which the
> unneeded newline is dropped since these strings are modified anyway by
> your patch.
That is what the submitted patch (2/12 specifically) did.
julia
prev parent reply other threads:[~2018-01-02 15:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 14:51 [PATCH 00/12] drop unneeded newline Julia Lawall
2017-12-27 14:51 ` [PATCH 01/12] dac960: " Julia Lawall
2017-12-27 14:51 ` [PATCH 02/12] dlm: " Julia Lawall
2017-12-27 14:51 ` [PATCH 03/12] net: dccp: " Julia Lawall
2018-01-02 18:50 ` David Miller
2017-12-27 14:51 ` [PATCH 04/12] ext2: " Julia Lawall
2017-12-28 4:30 ` Theodore Ts'o
2018-01-02 13:42 ` Jan Kara
2017-12-27 14:51 ` [PATCH 05/12] openvswitch: " Julia Lawall
2018-01-02 18:50 ` David Miller
2017-12-27 14:51 ` [PATCH 06/12] [S390] dasd: " Julia Lawall
2017-12-27 14:51 ` [PATCH 07/12] ARM: davinci: " Julia Lawall
2018-01-05 13:56 ` Sekhar Nori
2017-12-27 14:51 ` [PATCH 08/12] perf test: " Julia Lawall
2017-12-27 14:51 ` [PATCH 09/12] [media] pvrusb2: " Julia Lawall
2017-12-27 14:51 ` [PATCH 10/12] hpsa: " Julia Lawall
2018-01-04 4:29 ` Martin K. Petersen
2017-12-27 14:51 ` [PATCH 11/12] drm/amd/powerplay: " Julia Lawall
2017-12-27 15:40 ` Michel Dänzer
2017-12-27 20:11 ` Julia Lawall
2018-01-01 21:07 ` Alex Deucher
2017-12-27 14:51 ` [PATCH 12/12] hpfs: " Julia Lawall
2018-01-01 20:23 ` Mikulas Patocka
2018-01-02 13:52 ` [Cluster-devel] [PATCH 00/12] " Bob Peterson
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:56 ` Bob Peterson
2018-01-02 14:00 ` Julia Lawall
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:16 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801021615510.23552@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Bart.VanAssche@wdc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cluster-devel@redhat.com \
--cc=dccp@vger.kernel.org \
--cc=dev@openvswitch.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=esc.storagedev@microsemi.com \
--cc=jolsa@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox