From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751206AbeAYSrS (ORCPT ); Thu, 25 Jan 2018 13:47:18 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:35895 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbeAYSrR (ORCPT ); Thu, 25 Jan 2018 13:47:17 -0500 Date: Thu, 25 Jan 2018 19:46:57 +0100 (CET) From: Thomas Gleixner To: Lyude Paul cc: "Ghannam, Yazen" , "hpa@zytor.com" , "keith.busch@intel.com" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov Subject: Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel In-Reply-To: <1516904638.5161.1.camel@redhat.com> Message-ID: References: <1516744873.29151.3.camel@redhat.com> <1516757219.29151.7.camel@redhat.com> <1516816150.4109.2.camel@redhat.com> <1516823810.4109.26.camel@redhat.com> <1516904638.5161.1.camel@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jan 2018, Lyude Paul wrote: > I think you are right, apologies. Glad to know this isn't a regression in the > IRQ handling code :). It looks like our nouveau problems are probably coming > from the fact that we don't just leave IRQs setup through suspend/resume which > as far as I can tell, is probably not the correct thing to do. If you tear down the interrupt, then you have to make sure that it's completely masked and disabled on the device side (including MSI). Thanks, tglx