From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CBFC04AB1 for ; Mon, 13 May 2019 09:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A33A52146F for ; Mon, 13 May 2019 09:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbfEMJAb (ORCPT ); Mon, 13 May 2019 05:00:31 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:38115 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfEMJAb (ORCPT ); Mon, 13 May 2019 05:00:31 -0400 X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="305784263" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:00:01 +0200 Date: Mon, 13 May 2019 10:59:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Amelie Delaunay cc: Lee Jones , Linus Walleij , Alexandre Torgue , Maxime Coquelin , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, kbuild-all@01.org, Julia Lawall Subject: Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings In-Reply-To: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> Message-ID: References: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 > drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression > compared with zero: type < 0 > > Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Signed-off-by: Amelie Delaunay Acked-by: Julia Lawall > --- > drivers/pinctrl/pinctrl-stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index bcd8126..3bd5d6f 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, > struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > u32 param = pinconf_to_config_param(*config); > struct pinctrl_gpio_range *range; > - u32 dir, type, pupd; > + int dir, type, pupd; > u32 arg = 0; > int ret; > > -- > 2.7.4 > >