From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Yi Wang <wang.yi59@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Zhong Shiqi <zhong.shiqi@zte.com.cn>
Subject: Re: [PATCH v2] coccicheck: support $COCCI being defined as a directory
Date: Thu, 24 Oct 2019 09:58:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910240956450.4479@hadrien> (raw)
In-Reply-To: <37ad0bcd-941d-e02e-ae99-e89f2ce98ff0@web.de>
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
On Thu, 24 Oct 2019, Markus Elfring wrote:
> > Second the commit log could be more concise as:
>
> I like your desire for choosing a more appropriate commit message.
>
>
> > Allow defining COCCI as a directory that contains .cocci files.
>
> I would prefer to concentrate the patch subject on other information.
>
>
> > In general, at least in simple cases, it is not necessary to mention the
> > name of the file you are modifying in the comit log, because one can see
> > that just below from looking at the diffstat and the patch.
>
> This view can be reasonable. - How does it fit to the usual requirement
> for the specification of a “subsystem” (or “prefix”) according to the
> canonical patch format?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656
Huh? I was talking about the log message, not the subject line. Likewise
"Allow defining..." was not proposed as a subject line, but as the log
message. With that degree of orientation, I think one can look at the
code and figure out what the intent is. At least if one knows the meaning
of -d.
julia
next prev parent reply other threads:[~2019-10-24 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 6:04 [PATCH v2] coccicheck:support $COCCI being defined as a directory zhongshiqi
2019-10-24 6:19 ` Julia Lawall
2019-10-24 7:55 ` [PATCH v2] coccicheck: support " Markus Elfring
2019-10-24 7:58 ` Julia Lawall [this message]
2019-10-24 9:11 ` [v2] " Markus Elfring
2019-10-24 7:06 ` [PATCH v2] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910240956450.4479@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=zhong.shiqi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox