From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51503C432C0 for ; Mon, 2 Dec 2019 15:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CE4220717 for ; Mon, 2 Dec 2019 15:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727484AbfLBPMV (ORCPT ); Mon, 2 Dec 2019 10:12:21 -0500 Received: from gentwo.org ([3.19.106.255]:39610 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfLBPMV (ORCPT ); Mon, 2 Dec 2019 10:12:21 -0500 Received: by gentwo.org (Postfix, from userid 1002) id 3EC1F3EF27; Mon, 2 Dec 2019 15:12:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 3BED73EC03; Mon, 2 Dec 2019 15:12:20 +0000 (UTC) Date: Mon, 2 Dec 2019 15:12:20 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Andrew Morton cc: Yu Zhao , Pekka Enberg , David Rientjes , Joonsoo Kim , "Kirill A . Shutemov" , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [FIX] slub: Remove kmalloc under list_lock from list_slab_objects() V2 In-Reply-To: <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> Message-ID: References: <20190914000743.182739-1-yuzhao@google.com> <20191108193958.205102-1-yuzhao@google.com> <20191108193958.205102-2-yuzhao@google.com> <20191109230147.GA75074@google.com> <20191110184721.GA171640@google.com> <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Nov 2019, Andrew Morton wrote: > > Perform the allocation in free_partial() before the list_lock is taken. > > No response here? It looks a lot simpler than the originally proposed > patch? Yup. I prefer this one but its my own patch so I cannot Ack this.