From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740D2C32771 for ; Thu, 9 Jan 2020 12:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 549532075D for ; Thu, 9 Jan 2020 12:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730750AbgAIMEu (ORCPT ); Thu, 9 Jan 2020 07:04:50 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:44002 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730101AbgAIMEu (ORCPT ); Thu, 9 Jan 2020 07:04:50 -0500 X-IronPort-AV: E=Sophos;i="5.69,413,1571695200"; d="scan'208";a="430608229" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 13:04:48 +0100 Date: Thu, 9 Jan 2020 13:04:48 +0100 (CET) From: Julia Lawall X-X-Sender: julia@hadrien To: Markus Elfring cc: Wen Yang , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Gilles Muller , Greg Kroah-Hartman , Masahiro Yamada , =?ISO-8859-15?Q?Matthias_M=E4nnich?= , Michal Marek , Nicolas Palix , Thomas Gleixner Subject: Re: [v2] coccinelle: semantic patch to check for inappropriate do_div() calls In-Reply-To: Message-ID: References: <20200107170240.47207-1-wenyang@linux.alibaba.com> <9a2b7d00-442e-0c1b-73cc-aed2bbecd13a@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-300527455-1578571488=:10786" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-300527455-1578571488=:10786 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 9 Jan 2020, Markus Elfring wrote: > >> Thus I suggest now to split the source code search pattern into > >> four separate rules. > > > > Why? > > Does the Coccinelle software ensure that a variable like “r.ul” contains > really useful data even if the expected branch of the SmPL disjunction > was occasionally not matched? The python code will only be executed if it does. julia --8323329-300527455-1578571488=:10786--