From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D34C43331 for ; Tue, 31 Mar 2020 11:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E97420838 for ; Tue, 31 Mar 2020 11:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730563AbgCaLnl (ORCPT ); Tue, 31 Mar 2020 07:43:41 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7499 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730426AbgCaLnk (ORCPT ); Tue, 31 Mar 2020 07:43:40 -0400 X-IronPort-AV: E=Sophos;i="5.72,327,1580770800"; d="scan'208";a="443154920" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 13:43:05 +0200 Date: Tue, 31 Mar 2020 13:43:04 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Vetter cc: Daniel Vetter , kbuild-all@lists.01.org, Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: fix ifnullfree.cocci warnings In-Reply-To: <20200331074720.GD2363188@phenom.ffwll.local> Message-ID: References: <20200331074720.GD2363188@phenom.ffwll.local> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2020, Daniel Vetter wrote: > On Fri, Mar 27, 2020 at 09:11:44AM +0100, Julia Lawall wrote: > > NULL check before kfree is not needed. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > > --- > > > > tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > > Hm this doesn't apply anymore, the patch is for an interim state (because > bisectability). Care to regen (the pattern still exists), I'm happy to > apply. Maybe 0-day will produce it again? julia > -Daniel > > > head: 9e1ed9fb1eb0a4bc43a26365c592d3095286038b > > commit: c6603c740e0e3492c9c95fdab833375bf7117b6b [1587/1636] drm: add managed resources tied to drm_device > > :::::: branch date: 8 hours ago > > :::::: commit date: 9 hours ago > > > > Up to you, if you tihnk it is useful... > > > > drm_drv.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- a/drivers/gpu/drm/drm_drv.c > > +++ b/drivers/gpu/drm/drm_drv.c > > @@ -837,8 +837,9 @@ static void drm_dev_release(struct kref > > if (!dev->driver->release && !dev->managed.final_kfree) { > > WARN_ON(!list_empty(&dev->managed.resources)); > > kfree(dev); > > - } else if (dev->managed.final_kfree) > > + } else { > > kfree(dev->managed.final_kfree); > > + } > > } > > > > /** > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch >