From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D068BC433E0 for ; Mon, 8 Jun 2020 05:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B16B02076A for ; Mon, 8 Jun 2020 05:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728652AbgFHF7b (ORCPT ); Mon, 8 Jun 2020 01:59:31 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:10459 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgFHF7b (ORCPT ); Mon, 8 Jun 2020 01:59:31 -0400 X-IronPort-AV: E=Sophos;i="5.73,487,1583190000"; d="scan'208";a="453434732" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 07:59:29 +0200 Date: Mon, 8 Jun 2020 07:59:29 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Al Viro cc: "Rodolfo C. Villordo" , Forest Bond , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Forest Bond ,Greg Kroah-Hartman ,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org In-Reply-To: <20200608054614.GO23230@ZenIV.linux.org.uk> Message-ID: References: <20200607224156.GA24090@ip-172-31-24-31.ec2.internal> <20200608054614.GO23230@ZenIV.linux.org.uk> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2020, Al Viro wrote: > On Sun, Jun 07, 2020 at 10:41:56PM +0000, Rodolfo C. Villordo wrote: > > Multiple line over 80 characters fixes by splitting in multiple lines. > > Warning found by checkpatch.pl > > I doubt that checkpatch.pl can catch the real problems there: > > * Hungarian Notation Sucks. Really. > * so does CamelCase, especially for wonders like s_uGetRTSCTSRsvTime Rodolfo, If you work hard with Coccinelle and python scripting, it can help with the first two problems. julia > * local variables are useful > * if a long expression keeps cropping up all over the place, you > probably are missing an inline helper. > > PS: this > > - buf->time_stamp_off_a = vnt_time_stamp_off(pDevice, wCurrentRate); > > - buf->time_stamp_off_b = vnt_time_stamp_off(pDevice, pDevice->byTopCCKBasicRate); > > + buf->time_stamp_off_a = > > + vnt_time_stamp_off(pDevice, wCurrentRate); > > + buf->time_stamp_off_b = > > + vnt_time_stamp_off(pDevice, > > + pDevice->byTopCCKBasicRate); > is no improvement. >