From: Julia Lawall <julia.lawall@inria.fr>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: corbet@lwn.net, mchehab+huawei@kernel.org, dlatypov@google.com,
davidgow@google.com, linux-doc@vger.kernel.org,
linux-sparse@vger.kernel.org, cocci@inria.fr,
smatch@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, dan.carpenter@oracle.com,
julia.lawall@inria.fr
Subject: Re: [PATCH v2 2/2] Documentation: dev-tools: Enhance static analysis section with discussion
Date: Wed, 30 Mar 2022 10:06:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2203301005010.2592@hadrien> (raw)
In-Reply-To: <11f4750c6d4c175994dfd36d1ff385f68f61bd02.1648593132.git.marcelo.schmitt1@gmail.com>
> +Strong points of Smatch and Coccinelle
> +--------------------------------------
> +
> +Coccinelle is probably the easiest for writing checks. It works before the
> +pre-compiler so it's easier to check for bugs in macros using Coccinelle.
pre-processor
> +Coccinelle also writes patches fixes for you which no other tool does.
writes patches fixes -> creates patches
> +
> +With Coccinelle you can do a mass conversion from
you can -> you can, for example,
julia
> +``kmalloc(x * size, GFP_KERNEL)`` to ``kmalloc_array(x, size, GFP_KERNEL)``, and
> +that's really useful. If you just created a Smatch warning and try to push the
> +work of converting on to the maintainers they would be annoyed. You'd have to
> +argue about each warning if can really overflow or not.
> +
> +Coccinelle does no analysis of variable values, which is the strong point of
> +Smatch. On the other hand, Coccinelle allows you to do simple things in a simple
> +way.
> --
> 2.35.1
>
>
prev parent reply other threads:[~2022-03-30 8:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 23:21 [PATCH v2 0/2] Add a section for static analysis tools Marcelo Schmitt
2022-03-29 23:22 ` [PATCH v2 1/2] Documentation: dev-tools: " Marcelo Schmitt
2022-03-29 23:48 ` Daniel Latypov
2022-03-30 2:33 ` David Gow
2022-03-30 8:04 ` Julia Lawall
2022-03-29 23:23 ` [PATCH v2 2/2] Documentation: dev-tools: Enhance static analysis section with discussion Marcelo Schmitt
2022-03-30 2:48 ` David Gow
2022-03-30 8:07 ` Julia Lawall
2022-03-30 19:30 ` Marcelo Schmitt
2022-04-01 0:18 ` David Gow
2022-03-31 8:14 ` Dan Carpenter
2022-04-01 0:19 ` David Gow
2022-03-30 8:06 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2203301005010.2592@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox