The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Josh Boyer <jwboyer@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	viro@zeniv.linux.org.uk
Subject: Re: latest list of unused Kconfig variables
Date: Wed, 13 Feb 2008 10:32:35 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802131031040.30876@localhost.localdomain> (raw)
In-Reply-To: <20080213151628.GA10915@uranus.ravnborg.org>

On Wed, 13 Feb 2008, Sam Ravnborg wrote:

> On Wed, Feb 13, 2008 at 10:07:27AM -0500, Robert P. J. Day wrote:
> > On Wed, 13 Feb 2008, Josh Boyer wrote:
> >
> > > On Wed, 13 Feb 2008 03:56:34 -0500 (EST)
> > > "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
> >
> > > >   now that 2.6.25-rc1 is out, i can start updating the output from
> > > > my scanning scripts.  the first updated output is the list of
> > > > currently unused Kconfig variables -- variables that are defined
> > > > in some Kconfig file somewhere but appear to be entirely unused
> > > > throughout the source tree.
> > > >
> > > >   latest output here, sorted by architecture:
> > > >
> > > > http://www.crashcourse.ca/wiki/index.php/Unused_CONFIG_variables
> > > >
> > > > as always, there will probably be some false positives for one
> > > > reason or another.
> > > >
> > > >   output from the other scanning scripts will be up in short order.
> > >
> > > You have lots of false positives (or something) for arch/powerpc.
> > > Seems your script picked up #define names and comments that happen
> > > to match a Kconfig variable?
> >
> > it always will, given the proclivity of some folks to define their own
> > variables with a "CONFIG_" prefix.  as i point out on the wiki page, i
> > make no attempt to cull that list, i just print it as is, and readers
> > will have to peruse the list carefully to see what's meaningful and
> > what isn't.
>
> CONFIG_* should in the kernel be assumed a reserved namespace for
> kconifg. So any use of variables/defines named CONFIG_* which is not
> a kconfig symbol is a bug.

heh ... good luck with *that*:

$ grep -r "^#define CONFIG_" * | wc -l
752
$

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

  reply	other threads:[~2008-02-13 15:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  8:56 latest list of unused Kconfig variables Robert P. J. Day
2008-02-13  9:20 ` Paul Mundt
2008-02-13  9:26   ` Robert P. J. Day
2008-02-13 13:32 ` Josh Boyer
2008-02-13 15:07   ` Robert P. J. Day
2008-02-13 15:16     ` Sam Ravnborg
2008-02-13 15:32       ` Robert P. J. Day [this message]
2008-02-13 15:33     ` Josh Boyer
2008-02-13 15:44       ` Robert P. J. Day
2008-02-13 17:46         ` Sam Ravnborg
2008-02-13 17:58           ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802131031040.30876@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=jwboyer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox