From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Austin Clements <amdragon+kernelbugzilla@mit.edu>,
Ingo Molnar <mingo@elte.hu>, john stultz <johnstul@us.ibm.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] signals: sigqueue_free: don't free sigqueue if it is queued
Date: Wed, 21 May 2008 11:49:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805211146350.3081@woody.linux-foundation.org> (raw)
In-Reply-To: <20080521184245.5BABF26FA24@magilla.localdomain>
On Wed, 21 May 2008, Roland McGrath wrote:
>
> Just properly removing the sigqueue entry and fixing the pending set is
> looking pretty good. Why was it we didn't do that?
I thought we didn't even know which queue it was pending on if it was
already on a thread-local queue. So we could remove the entry, but I
always objected to the games with the pending bit.
Just removing the entry I'm ok with, it was the (pointless and misleading)
use of recalc_sigpending() that started the whole discussion. The fact
that we then also have that "which signal is pending" bit in front of the
queue was something that came up later.
Linus
next prev parent reply other threads:[~2008-05-21 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 15:14 [PATCH 1/3] signals: sigqueue_free: don't free sigqueue if it is queued Oleg Nesterov
2008-05-21 2:20 ` Roland McGrath
2008-05-21 11:54 ` Oleg Nesterov
2008-05-21 18:42 ` Roland McGrath
2008-05-21 18:49 ` Linus Torvalds [this message]
2008-05-21 19:33 ` Roland McGrath
2008-05-21 20:07 ` Linus Torvalds
2008-05-21 23:01 ` Roland McGrath
2008-05-22 11:12 ` Oleg Nesterov
2008-05-22 11:55 ` Oleg Nesterov
2008-05-22 21:50 ` Roland McGrath
2008-05-22 21:18 ` Oleg Nesterov
2008-05-23 1:41 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805211146350.3081@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=amdragon+kernelbugzilla@mit.edu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@googlemail.com \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox