From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Adrian Bunk <bunk@kernel.org>
Cc: Michael Buesch <mb@bu3sch.de>,
"John W. Linville" <linville@tuxdriver.com>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
Date: Thu, 5 Jun 2008 14:34:35 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0806051432220.6496@localhost.localdomain> (raw)
In-Reply-To: <20080605182945.GO1469@cs181133002.pp.htv.fi>
On Thu, 5 Jun 2008, Adrian Bunk wrote:
> This patch fixes a typo in the name of a config variable.
>
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
> index 01fbdf5..942e387 100644
> --- a/include/linux/ssb/ssb_driver_gige.h
> +++ b/include/linux/ssb/ssb_driver_gige.h
> @@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
> /* Get the device MAC address */
> static inline void ssb_gige_get_macaddr(struct pci_dev *pdev, u8 *macaddr)
> {
> -#ifdef CONFIG_BCM947XX
> +#ifdef CONFIG_BCM47XX
> char *res = nvram_get("et0macaddr");
> if (res)
> memcpy(macaddr, res, 6);
>
just FYI, there are more (admittedly aesthetic) references to
BCM947XX in the MIPS directory:
$ grep -r "BCM947XX" *
include/linux/ssb/ssb_driver_gige.h:#ifdef CONFIG_BCM947XX
include/asm-mips/mach-bcm47xx/war.h:#ifndef __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#define __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#endif /* __ASM_MIPS_MACH_BCM947XX_WAR_H */
$
whether you want to do anything about those is up to you.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================
next prev parent reply other threads:[~2008-06-05 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 18:29 [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix Adrian Bunk
2008-06-05 18:34 ` Robert P. J. Day [this message]
2008-06-05 18:42 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806051432220.6496@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox