From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Hideo Saito <saito@densan.co.jp>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: follow_page() performance regressions
Date: Tue, 1 Jul 2008 08:43:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807010837510.20870@hp.linux-foundation.org> (raw)
In-Reply-To: <20080701052543.GA4726@linux-sh.org>
On Tue, 1 Jul 2008, Paul Mundt wrote:
>
> So yes, the ZERO_PAGE handling in follow_page() is causing the slow-down here.
I suspect it could be any of:
- actual code generation differences in follow_page() (some SH person
needs to check that)
- some cache issue on SH. ZERO_PAGE is a single page at a fixed virtual
address, while it used to populate the page tables with individual
pages. Normally, this should be *better* for caching, but maybe there
is some conflict? What kind of caches does SH have (virtually indexed?)
- hackbench relying on follow_page() to populate the page tables, which
it no longer does for anonymous areas (using ZERO_PAGE directly
instead).
Again, normally this would speed things up (fewer TLB misses etc), but
if it then causes a new page fault that used to have been covered by
follow_page(), who knows?
What does hackbench actually do? Anybody?
Linus
next prev parent reply other threads:[~2008-07-01 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080701.132439.68562265.saito@densan.co.jp>
2008-07-01 5:25 ` follow_page() performance regressions Paul Mundt
2008-07-01 15:43 ` Linus Torvalds [this message]
2008-07-01 16:35 ` Linus Torvalds
2008-07-03 1:57 ` Hideo Saito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807010837510.20870@hp.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=saito@densan.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox