The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: Hannes Reinecke <hare@suse.de>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch make struct scsi_dh_devlist's static
Date: Mon, 11 Aug 2008 11:00:19 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0808111058590.3462@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1218477013.16794.7.camel@chandra-ubuntu>



On Mon, 11 Aug 2008, Chandra Seetharaman wrote:
>
> This patch makes several needlessly global struct scsi_dh_devlist's 
> static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Acked-by: Chandra Seetharaman <sekharan@us.ibm.com>

This is not a valid sign-off chain.

Was the patch originally done by Adrian? If so, where is the

	From: Adrian Bunk <bunk@kernel.org>

at the top?

And since you're forwarding it, you should be signing off on it, not just 
acking it. Otherwise, the next person in the chain can't sign off on it 
and take it.

		Linus

  reply	other threads:[~2008-08-11 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11 17:50 [2.6 patch make struct scsi_dh_devlist's static Chandra Seetharaman
2008-08-11 18:00 ` Linus Torvalds [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-08-11 18:59 Chandra Seetharaman
2008-08-10 21:31 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0808111058590.3462@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox