From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: apic - unify APIC_DIVISOR
Date: Fri, 10 Oct 2008 20:17:49 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.1.10.0810102011260.19747@ftp.linux-mips.org> (raw)
In-Reply-To: <20081010190350.GA25931@linux-os.sc.intel.com>
On Fri, 10 Oct 2008, Venki Pallipadi wrote:
> If there is no pressing reason to change the initial calibration value, how
> about the simple patch below.
>
> The 10^9 value that is used for 100 mS calibration time is pretty big as
> tglx's comment points out. We will only underflow it if there is a
> bus clock running at 10 GHz * 16 = 160 Ghz.
>
> This way we will not fix something that is not really broken today and will not
> break in foreseeable future.
I am fine with this version too. The initial count value used for
calibration is really arbitrary -- for all the systems I have seen the
APIC clock was in the sub-MHz range. And 64-bit hardware runs both code
variations so the choice of what the 32-bit code version does is
appropriate as it is also known to work with 32-bit equipment.
Maciej
prev parent reply other threads:[~2008-10-10 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 15:00 [PATCH] x86: apic - unify APIC_DIVISOR Cyrill Gorcunov
2008-10-10 15:07 ` Ingo Molnar
2008-10-10 15:47 ` Maciej W. Rozycki
2008-10-10 16:11 ` Pallipadi, Venkatesh
2008-10-10 16:31 ` Cyrill Gorcunov
2008-10-10 17:07 ` Pallipadi, Venkatesh
2008-10-10 17:16 ` Cyrill Gorcunov
2008-10-10 19:03 ` Venki Pallipadi
2008-10-10 19:11 ` Cyrill Gorcunov
2008-10-10 19:17 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0810102011260.19747@ftp.linux-mips.org \
--to=macro@linux-mips.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox