public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	David Daney <ddaney@caviumnetworks.com>,
	gcc@gcc.gnu.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-mips <linux-mips@linux-mips.org>,
	linux-kernel@vger.kernel.org,
	Adam Nemet <anemet@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Make BUG() __noreturn.
Date: Mon, 24 Nov 2008 19:04:40 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0811241854520.3793@ftp.linux-mips.org> (raw)
In-Reply-To: <20081121221619.GB28154@linux-mips.org>

On Fri, 21 Nov 2008, Ralf Baechle wrote:

> MIPS ISA newer than MIPS I also have conditional break codes allowing
> something like this:
> 
> #define BUG_ON(condition)                                               \
> do {                                                                    \
>         __asm__ __volatile__("tne $0, %0, %1"                           \
>                              : : "r" (condition), "i" (BRK_BUG));       \
> } while (0)
> 
> that is test of condition and the trap as a single instruction.  Note there
> are break and trap instructions on MIPS and they are basically doing the
> same job ...

 GCC is actually smart enough to combine sequences like:

if (something)
	__builtin_trap();

into appropriate conditional trap instructions on MIPS.  As noted by David 
trap codes other than the default cannot be emitted this way though.

  Maciej

  reply	other threads:[~2008-11-24 19:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21  1:26 [PATCH] MIPS: Make BUG() __noreturn David Daney
2008-11-21 10:00 ` Alan Cox
2008-11-21 10:27   ` Geert Uytterhoeven
2008-11-21 11:14     ` Maciej W. Rozycki
2008-11-21 12:58       ` Andreas Schwab
2008-11-21 16:40     ` David Daney
2008-11-21 18:46       ` Geert Uytterhoeven
2008-11-21 22:16         ` Ralf Baechle
2008-11-24 19:04           ` Maciej W. Rozycki [this message]
2008-11-21 23:00 ` Andrew Morton
2008-11-21 23:48   ` David Daney
2008-11-23  9:58   ` Ingo Molnar
2008-11-24  9:20     ` Ralf Baechle
2008-11-25  0:16     ` Jeremy Fitzhardinge
2008-11-22  9:39 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0811241854520.3793@ftp.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=anemet@caviumnetworks.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=gcc@gcc.gnu.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox