From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <srostedt@redhat.com>,
dsaxena@plexity.net, linux-kernel@vger.kernel.org,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: TSC not updating after resume: Bug or Feature?
Date: Sun, 21 Dec 2008 20:43:56 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0812212031220.4548@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0812211639210.3376@localhost.localdomain>
On Sun, 21 Dec 2008, Thomas Gleixner wrote:
> On Thu, 18 Dec 2008, Rafael J. Wysocki wrote:
> > > 5b7dba4: sched_clock: prevent scd->clock from moving backwards
> > >
> > > and the bug triggered by hibernation fixed instead.
>
> Hmm. Depending on the hibernation sleep time we can end up with a
> pretty long delta between the pre suspend and the post resume call to
> __update_sched_clock().
>
> I have the feeling that sched_clock looks into stale values after
> resume and the first call to __update_sched_clock() trips over the
> stale scd->clock value. Shaggy's patch brings scd->clock into the mix
> and that might cause the whole machinery to blow up on resume.
>
> Also we need to investigate whether sched_clock is referencing gtod
> values _before_ timekeeping is resume.
I checked the two bugzillas (12149 & 12155) and both reporters have
hpet=force on the command line.
One of the reporters said: "If I de-select CONFIG_HPET_TIMER then the
issue went away ..."
It looks like this was not further investigated. Is this problem
reproducible on other systems as well ?
Thanks,
tglx
next prev parent reply other threads:[~2008-12-21 19:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 17:27 TSC not updating after resume: Bug or Feature? Deepak Saxena
2008-12-17 17:50 ` Steven Rostedt
2008-12-18 9:24 ` Peter Zijlstra
2008-12-18 12:39 ` Ingo Molnar
2008-12-18 22:19 ` Rafael J. Wysocki
2008-12-18 22:25 ` Dave Kleikamp
2008-12-18 23:39 ` Rafael J. Wysocki
2008-12-21 16:26 ` Thomas Gleixner
2008-12-21 19:43 ` Thomas Gleixner [this message]
2008-12-21 22:43 ` Fabio Comolli
2008-12-22 14:48 ` Thomas Gleixner
2008-12-22 15:00 ` Ingo Molnar
2008-12-22 18:47 ` Thomas Gleixner
2008-12-22 20:36 ` Thomas Gleixner
2008-12-22 20:39 ` Fabio Comolli
2008-12-22 21:13 ` Thomas Gleixner
2008-12-22 21:35 ` Fabio Comolli
2008-12-22 22:05 ` Thomas Gleixner
2008-12-22 22:12 ` Fabio Comolli
2008-12-22 22:16 ` Thomas Gleixner
2008-12-22 22:29 ` Fabio Comolli
2008-12-22 22:33 ` Thomas Gleixner
2008-12-23 0:28 ` Rafael J. Wysocki
2008-12-23 19:42 ` Fabio Comolli
2008-12-24 14:09 ` Pavel Machek
2008-12-26 8:47 ` Peter Zijlstra
2008-12-22 20:19 ` Fabio Comolli
2008-12-21 20:54 ` Thomas Gleixner
2008-12-23 0:47 ` Rafael J. Wysocki
2008-12-23 7:03 ` Thomas Gleixner
2008-12-23 14:15 ` Rafael J. Wysocki
2008-12-21 21:19 ` Thomas Gleixner
2008-12-23 22:03 ` Deepak Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0812212031220.4548@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=shaggy@linux.vnet.ibm.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox