public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Salman Qazi <sqazi@google.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andi Kleen <andi@firstfloor.org>,
	Dave Hansen <haveblue@us.ibm.com>
Subject: Re: Another Performance Regression in write() syscall
Date: Tue, 24 Feb 2009 09:29:51 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0902240924490.3111@localhost.localdomain> (raw)
In-Reply-To: <1235494732.26788.256.camel@nimitz>



On Tue, 24 Feb 2009, Dave Hansen wrote:
> 
> Yeah, that's a good point.  Are we sure that's what is happening here,
> though?  That's one thing a profile would hopefully help with.

One thing to note is that _if_ it's purely an issue of nontemporal stores 
vs normal stores, then profiling is very likely going to be almost 
entirely useless. You'll get "results", but the results have nothing 
what-so-ever to do with reality or anything interesting.

The nontemporal stores may stand out in the profiles, but the actual 
performance impact will be all about whether totally unrelated code got 
cache misses or not. Quite often those cache misses will also be in user 
mode, and very possibly in other processes.

So profiles can certainly be interesting, but if Salman says that his 
patch makes a difference for his benchmark, then profiling is almost 
certainly not interesting FOR THAT PATCH. It's interesting mainly as a way 
to look at whether there are then also _other_ issues that are worth 
addressing (ie the whole atime thing is in a whole different dimension 
and an independent issue).

			Linus

  reply	other threads:[~2009-02-24 17:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  6:05 Another Performance Regression in write() syscall Salman Qazi
2009-02-24  6:25 ` Dave Hansen
2009-02-24  8:47   ` Nick Piggin
2009-02-24 16:58     ` Dave Hansen
2009-02-24 17:29       ` Linus Torvalds [this message]
2009-02-24 17:50         ` Ingo Molnar
2009-02-25  3:49       ` Nick Piggin
2009-02-25  1:05   ` Salman Qazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0902240924490.3111@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=haveblue@us.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=sqazi@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox