From: Linus Torvalds <torvalds@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
LKML <linux-kernel@vger.kernel.org>,
Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH 2/2] unaligned: add load/store_{endian}_noalign API
Date: Mon, 2 Mar 2009 16:18:26 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0903021616440.3111@localhost.localdomain> (raw)
In-Reply-To: <1236038818.5756.12.camel@brick>
On Mon, 2 Mar 2009, Harvey Harrison wrote:
>
> Add a typed API with the usual argument ordering and use load/store,
> this API is also consistent with the aligned versions.
This naming is horrible. It doesn't match the normal pattern we have in
the kernel.
Why not just try to fix the current (well-named) "get_unaligned_le16()"
problems, instead of introducing a new (and badly named) version of them.
So NAK on both of these.
Linus
next prev parent reply other threads:[~2009-03-03 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 0:06 [PATCH 2/2] unaligned: add load/store_{endian}_noalign API Harvey Harrison
2009-03-03 0:18 ` Linus Torvalds [this message]
2009-03-03 0:38 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903021616440.3111@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=geert@linux-m68k.org \
--cc=harvey.harrison@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox