public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Ingo Molnar <mingo@elte.hu>,
	Josh Boyer <jwboyer@linux.vnet.ibm.com>,
	ltt-dev@lists.casi.polymtl.ca, danymadden@us.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols
Date: Tue, 17 Mar 2009 00:52:31 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0903170048120.29264@localhost.localdomain> (raw)
In-Reply-To: <20090316231122.GA18113@Krystal>

On Mon, 16 Mar 2009, Mathieu Desnoyers wrote:
> Mathieu :
> 
> This build problem was exhibited because of the added
> EXPORT_SYMBOL(irq_to_desc) in the LTTng tree, but only on powerpc.
> 
> Applies on 2.6.29-rc8.

Applies, but that does not make it a useful patch per se.

2.6.29-rc8/include/linux/irqnr.h has (condensed excerpt):

#ifndef CONFIG_GENERIC_HARDIRQS
#define nr_irqs                 NR_IRQS
#define irq_to_desc(irq)        (&irq_desc[irq])
#else
extern int nr_irqs;
extern struct irq_desc *irq_to_desc(unsigned int irq);
#endif  /* CONFIG_GENERIC_HARDIRQS */

And this adds right below of the #endif:
 
> +++ linux-2.6-lttng/include/linux/irqnr.h	2009-03-16 18:40:01.000000000 -0400
> @@ -38,6 +38,10 @@ extern struct irq_desc *irq_to_desc(unsi
>  
>  #endif /* CONFIG_GENERIC_HARDIRQS */
>  
> +extern int nr_irqs;
> +struct irq_desc;
> +extern struct irq_desc *irq_to_desc(unsigned int irq);
> +

Is this a contribution to the "most useless patch of the week"
contest ?

You have my vote.

    tglx



  reply	other threads:[~2009-03-16 23:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090316182227.GA2444@yoda.jdub.homelinux.org>
     [not found] ` <20090316194459.GD11878@Krystal>
     [not found]   ` <20090316200115.GA22538@yoda.jdub.homelinux.org>
     [not found]     ` <20090316202500.GA13872@Krystal>
     [not found]       ` <20090316205829.GB22538@yoda.jdub.homelinux.org>
     [not found]         ` <20090316215337.GB15119@Krystal>
     [not found]           ` <20090316220518.GD22538@yoda.jdub.homelinux.org>
2009-03-16 23:11             ` [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols Mathieu Desnoyers
2009-03-16 23:52               ` Thomas Gleixner [this message]
2009-03-17  0:08                 ` [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols v2 Mathieu Desnoyers
2009-03-17  0:34                   ` Josh Boyer
2009-03-17  8:29                   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0903170048120.29264@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=danymadden@us.ibm.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox