Re: [PATCH 10/10 -tip] x86: collect_cpu_info() of AMD user of Microcode feature

Andreas Herrmann
2009-05-13T05:48:58Z

On Tue, May 12, 2009 at 09:14:38PM +0530, Jaswinder Singh Rajput wrote:
>
> use X86_FEATURE_MICROCODE to determine microcode update
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

NAK.

> arch/x86/kernel/microcode_amd.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
> index 453b579..1178638 100644
> --- a/arch/x86/kernel/microcode_amd.c
> +++ b/arch/x86/kernel/microcode_amd.c
> @@ -90,7 +90,8 @@ static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
> u32 dummy;
>
> memset(csig, 0, sizeof(*csig));
> - if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
> + if (c->x86_vendor != X86_VENDOR_AMD ||
> + !cpu_has(c, X86_FEATURE_MICROCODE)) {
> printk(KERN_WARNING "microcode: CPU%d: AMD CPU family 0x%x not "
> "supported\n", cpu, c->x86);
> return -1;
> --
> 1.6.0.6

Regards,
Andreas

--
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632