Re: [PATCH 3/10 -tip] x86: Add cpufeatures for Advanced Power Management

Jaswinder Singh Rajput
2009-05-21T05:10:33Z

On Wed, 2009-05-20 at 11:30 -0700, H. Peter Anvin wrote:
> Jaswinder Singh Rajput wrote:
> >
> > I think better I will show with the coding to get the clear picture.
> >
> > Currently we are using hardcoded x86_capability as [0], [2], [4], [5].
> >
> > Thomas prefer to use constant so may be we can define current system as:
> >
> > enum {
> > CPUID_0000_0001_EDX = 0, /* 0x00000001 edx */
> > CPUID_8000_0001_EDX, /* 0x80000001 edx */
> > CPUID_8086_0001_EDX, /* 0x80860001 edx */
> > CPUID_SOFT_MISC1, /* Software Misc1 */
> > CPUID_0000_0001_ECX, /* 0x00000001 ecx */
> > CPUID_C000_0001_EDX, /* 0xC0000001 edx */
> > CPUID_8000_0001_ECX, /* 0x80000001 ecx */
> > CPUID_SOFT_MISC2, /* Software Misc2 */
> > CPUID_SOFT_VIRTUAL, /* Software Virtualization */
> > };
> >
>
> This really seems clumsy to me. We don't refer to the individual words
> all that often; and more importantly, I think it'd be hard to get rid of
> all the places where the words are referenced.
>

OK. It was thomas request. I hope this explanation will be enough and
thomas have no objection in Advanced Power Management's cpufeatures
series.

Ingo: should I resend new cpufeatures series, or you can use this one.

Thanks,
--
JSR