Re: [PATCH 02/17] x86: add io_apic_ops to allow interception

Jeremy Fitzhardinge
2009-05-27T07:22:37Z

Ingo Molnar wrote:
> ok, could you please turn the whole IO-APIC code into a driver
> framework? I.e. all IO-APIC calls outside of
> arch/x86/kernel/apic/io_apic.c should be to some io_apic-> method.
>
> The advantage will be a proper abstraction for all IO-APIC details -
> not just a minimalistic one for Xen's need.
>
> Also, please name it 'struct io_apic' - similar to the 'struct apic'
> naming we have for the local APIC driver structure.

OK, I'll have a look at it. I think it could turn out quite nicely, and
possibly remove the need for some other other Xen hooks around the
place, as well as make the path for some other other upcoming things
clearer.

But in the meantime, would you consider taking the minimal ops approach
for this next merge window, and the full api in the next dev cycle?

Thanks,
J