Re: references to non-existent header files under include/linux

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Sat, 13 Jun 2009, Sam Ravnborg wrote:

> On Sat, Jun 13, 2009 at 09:35:42AM -0400, Robert P. J. Day wrote:
> >
> >   again, since this output is fairly short, this is a list of
> > references throughout the source tree of the form:
> >
> >   #include <linux/whatever>
> >
> > where there does not appear to be any such header file.  might be some
> > false positives but i'm not going to agonize over it.
> >
> >
> > === Missing: include/linux/bounds.h ===
> > include/linux/mmzone.h:18:#include <linux/bounds.h>
> > include/linux/page-flags.h:11:#include <linux/bounds.h>
> bounds.h is generated.
>
> > === Missing: include/linux/compile.h ===
> > arch/x86/boot/version.c:17:#include <linux/compile.h>
> > init/version.c:9:#include <linux/compile.h>
> compile.h is generated.

  which i would have recognized if i hadn't been reduced to drinking
decaf this morning.  *sigh*.

> The rest looks like real bugs.
> Please submit patches to fix them up.

  these days, i'm more partial to just doing the scan and, when the
official time comes, passing off the results to the various subsystem
maintainers, only because sometimes it's not immediately obvious what
the correct fix is.

  maybe it's a typo, maybe it's a partial feature commit where the
code should include the header file but the header file is yet to be
added, maybe it's part of code that is no longer even being compiled
due to changes in #ifdef's or Kconfig files, maybe it's for a
non-intel arch that i'm not set up to test, maybe ... anyway, you get
the idea.  and, in some cases, when the subsystem maintainer takes a
look at it, it might be that that single incorrect line represents a
much larger issue that only that maintainer should deal with.

  in short, i'll just be lazy and whine, and let others do the actual
fixing.  :-)

rday
--


========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday
========================================================================