From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <dvhltc@us.ibm.com>
Subject: [GIT pull] final futex fixes for 2.6.31
Date: Thu, 25 Jun 2009 20:15:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0906251940570.2767@localhost.localdomain> (raw)
In-Reply-To: <20090625100413.GD29980@elte.hu>
Linus,
I'm truly embarrassed to ask you to pull the latest futexes-for-linus
git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git futexes-for-linus
I did not just copy your suggestion blindly, I even wondered and
looked up the prototype in mm.h which has the 4th argument "int len"
and said to myself "hey, Linus is right as usual" while in reality
"len" is number of pages.
As I'm running out of brown paperbags I'm declaring all futex bugs
fixed by definition. Futex bugs which will be discovered from now on
are going to be automatically converted to documented features.
Thanks,
tglx
------------------>
Thomas Gleixner (1):
futex: request only one page from get_user_pages()
kernel/futex.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/futex.c b/kernel/futex.c
index 1c33711..794c862 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -299,7 +299,7 @@ void put_futex_key(int fshared, union futex_key *key)
static int fault_in_user_writeable(u32 __user *uaddr)
{
int ret = get_user_pages(current, current->mm, (unsigned long)uaddr,
- sizeof(*uaddr), 1, 0, NULL, NULL);
+ 1, 1, 0, NULL, NULL);
return ret < 0 ? ret : 0;
}
next prev parent reply other threads:[~2009-06-25 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 14:36 [PATCH V2] futex: Fix the write access fault problem for real Thomas Gleixner
2009-06-24 16:46 ` Linus Torvalds
2009-06-24 19:48 ` [GIT pull] futex fixes for 2.6.31 Thomas Gleixner
2009-06-25 2:43 ` Zhang, Yanmin
2009-06-25 9:56 ` Thomas Gleixner
2009-06-25 10:04 ` Ingo Molnar
2009-06-25 18:15 ` Thomas Gleixner [this message]
2009-06-25 18:26 ` [GIT pull] final " Linus Torvalds
2009-06-25 9:58 ` [PATCH] clarify get_user_pages() prototype Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906251940570.2767@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox