public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().
@ 2009-07-05  0:44 Robert P. J. Day
  2009-07-07  7:59 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2009-07-05  0:44 UTC (permalink / raw)
  To: Linux Kernel Mailing List, trivial


Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  get rid of that commented usage of the now defunct MODULE_PARM macro
simply because it pollutes a scan for actual references to that dead
macro.

diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
index 1edab7b..3136c88 100644
--- a/sound/oss/swarm_cs4297a.c
+++ b/sound/oss/swarm_cs4297a.c
@@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
 // rather than 64k as some of the games work more responsively.
 // log base 2( buff sz = 32k).

-//static unsigned long defaultorder = 3;
-//MODULE_PARM(defaultorder, "i");
-
 //
 // Turn on/off debugging compilation by commenting out "#define CSDEBUG"
 //
========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday
========================================================================

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().
  2009-07-05  0:44 [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM() Robert P. J. Day
@ 2009-07-07  7:59 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2009-07-07  7:59 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux Kernel Mailing List

On Sat, 4 Jul 2009, Robert P. J. Day wrote:

> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   get rid of that commented usage of the now defunct MODULE_PARM macro
> simply because it pollutes a scan for actual references to that dead
> macro.
> 
> diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
> index 1edab7b..3136c88 100644
> --- a/sound/oss/swarm_cs4297a.c
> +++ b/sound/oss/swarm_cs4297a.c
> @@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
>  // rather than 64k as some of the games work more responsively.
>  // log base 2( buff sz = 32k).
> 
> -//static unsigned long defaultorder = 3;
> -//MODULE_PARM(defaultorder, "i");
> -
>  //
>  // Turn on/off debugging compilation by commenting out "#define CSDEBUG"
>  //

Oh what a horrible driver anyway ...

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-07  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-05  0:44 [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM() Robert P. J. Day
2009-07-07  7:59 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox