From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: any remaining value to EXPORT_UNUSED_SYMBOL{,_GPL} macros?
Date: Wed, 15 Jul 2009 07:29:18 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0907150723560.22509@localhost> (raw)
i asked this on the kernel newbies list since it seemed fairly
trivial but perhaps it's better to ask it here. is there any value to
hanging onto those two macro definitions given this from
Documentation/feature-removal-schedule.txt:
What: Unused EXPORT_SYMBOL/EXPORT_SYMBOL_GPL exports
(temporary transition config option provided until then)
The transition config option will also be removed at the same time.
When: before 2.6.19
Why: Unused symbols are both increasing the size of the kernel binary
and are often a sign of "wrong API"
Who: Arjan van de Ven <arjan@linux.intel.com>
and that a scan of the entire source tree reveals:
$ grep -r EXPORT_UNUSED_SYMBOL *
fs/libfs.c:EXPORT_UNUSED_SYMBOL(simple_prepare_write);
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym) __EXPORT_SYMBOL(sym, "_unused")
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym) __EXPORT_SYMBOL(sym, "_unused_gpl")
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL(sym)
include/linux/module.h:#define EXPORT_UNUSED_SYMBOL_GPL(sym)
scripts/checkpatch.pl: ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
scripts/mod/modpost.c: { .str = "EXPORT_UNUSED_SYMBOL", .export = export_unused },
scripts/mod/modpost.c: { .str = "EXPORT_UNUSED_SYMBOL_GPL", .export = export_unused_gpl },
in short, one actual usage in fs/libfs.c, and a bunch of other
references that contribute nothing to their value.
thoughts? if these macros have been deprecated for a while, why not
just dump that final usage and get rid of them?
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
"Kernel Newbie Corner" column @ linux.com: http://cli.gs/WG6WYX
========================================================================
reply other threads:[~2009-07-15 11:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0907150723560.22509@localhost \
--to=rpjday@crashcourse.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox