From: Linus Torvalds <torvalds@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUG] lockup with the latest kernel
Date: Thu, 27 Aug 2009 21:05:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0908272059320.7223@eeepc.linux-foundation.org> (raw)
In-Reply-To: <4A9744F4.7010208@kernel.org>
On Fri, 28 Aug 2009, Tejun Heo wrote:
> >
> > x86: make x86_32 use tlb_64.c
> >
> > Impact: less contention when issuing invalidate IPI, cleanup
> >
> > Make x86_32 use the same tlb code as 64bit. The 64bit code uses
> > multiple IPI vectors for tlb shootdown to reduce contention. This
> > patch makes x86_32 allocate the same 8 IPIs as x86_64 and share the
> > code paths.
> >
> > Note that the usage of asmlinkage is inconsistent for x86_32 and 64
> > and calls for further cleanup. This has been noted with a FIXME
> > comment in tlb_64.c.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> >
> > I can easily hit this bug at this commit, but I ran for a week on the
> > commit before it. Thus I'm assuming this is the bug (but I'm not 100%
> > sure).
>
> Drat, why does it have to be mine? ;-)
>
> Joke aside, thank you very much for bisecting it.
>
> ...
> >> [13288.222084] EIP: 0060:[<c0110821>] EFLAGS: 00000002 CPU: 0
> >> [13288.222084] EIP is at default_send_IPI_mask_logical+0x53/0x92
Is this one perhaps fixed by b04e6373d694 ("x86: don't call
'->send_IPI_mask()' with an empty mask")
It sounds a _lot_ like that bug. Older dual-cpu x86 box, and APIC getting
confused by the occasional empty CPU mask, and then subsequent IPI's will
hang.
Linus
next prev parent reply other threads:[~2009-08-28 4:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 15:49 [BUG] lockup with the latest kernel Steven Rostedt
2009-08-19 15:50 ` Steven Rostedt
2009-08-19 16:18 ` Andrew Morton
2009-08-27 22:41 ` Steven Rostedt
2009-08-27 22:45 ` Steven Rostedt
2009-08-28 2:46 ` Tejun Heo
2009-08-28 2:52 ` Tejun Heo
2009-08-28 6:36 ` Ingo Molnar
2009-08-28 6:59 ` Tejun Heo
2009-08-28 4:05 ` Linus Torvalds [this message]
2009-08-28 16:15 ` Steven Rostedt
2009-08-28 18:33 ` Steven Rostedt
2009-09-09 2:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0908272059320.7223@eeepc.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox