From: Thomas Gleixner <tglx@linutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
linux-rt-users@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: Using set_irq_handler in set_irq_type callback?
Date: Wed, 7 Oct 2009 12:22:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0910071221140.9428@localhost.localdomain> (raw)
In-Reply-To: <20091007100756.GA5478@pengutronix.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 553 bytes --]
On Wed, 7 Oct 2009, Uwe Kleine-König wrote:
> I think the fix for that is adding something like:
>
> if (type & IRQ_TYPE_EDGE_BOTH)
> set_irq_handler(irq, handle_edge_irq);
> else
> set_irq_handler(irq, handle_level_irq);
>
> to the chip's .set_type callback. (Doing this directly fails, as
> .set_type holds desc->lock which set_irq_handler acquires, too. So
> maybe I need to code up a handler that checks how a given irq triggers
> and then calls handle_edge_irq or handle_level_irq.)
Nope. See __set_irq_handler_unlocked()
Thanks,
tglx
next prev parent reply other threads:[~2009-10-07 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 10:07 Using set_irq_handler in set_irq_type callback? Uwe Kleine-König
2009-10-07 10:22 ` Thomas Gleixner [this message]
2009-10-07 10:28 ` Russell King
2009-10-07 10:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0910071221140.9428@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox