The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	David Airlie <airlied@linux.ie>, Jonathan Corbet <corbet@lwn.net>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Vincent Sanders <vince@simtec.co.uk>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH RFC] frontend.c: Remove the BKL from agp_open
Date: Mon, 12 Oct 2009 12:11:51 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0910121209140.3658@localhost.localdomain> (raw)
In-Reply-To: <21d7e9970910120203k3b411796pf00e3453c4d2297b@mail.gmail.com>



On Mon, 12 Oct 2009, Dave Airlie wrote:

> On Mon, Oct 12, 2009 at 6:24 AM, John Kacur <jkacur@redhat.com> wrote:
> >
> > @David Airlie. I was looking at the agp driver for removal of the bkl
> > lock. From what I could tell, the mutex_lock(&(agp_fe.agp_mutex)) should
> > cover what we need. However, I may have easily missed something, and would
> > appreciate your review / comments on the patch.
> 
> This seems fine, though I suck at locking logic,
> 
> One thing to note is the number of users of this interface is probably
> close to 0,
> so even if this does break something we probably won't ever find out.
> 
> Dave.
> 

Hmnn, you are listed as the maintainer - don't at least YOU use this 
driver? Also, if it seem fine to you, can I have an ack?

Thanks

  reply	other threads:[~2009-10-12 10:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 20:24 [PATCH RFC] frontend.c: Remove the BKL from agp_open John Kacur
2009-10-12  9:03 ` Dave Airlie
2009-10-12 10:11   ` John Kacur [this message]
2009-10-12 10:19     ` Dave Airlie
2009-10-14 15:51 ` [tip:bkl/drivers] agp: " tip-bot for John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0910121209140.3658@localhost.localdomain \
    --to=jkacur@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox