public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: simplify numerous param.h's by including <asm-generic/param.h>?
Date: Tue, 29 Dec 2009 12:30:23 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0912291224520.2860@localhost> (raw)


  a brief perusal of the numerous param.h files under
arch/<arch>/include/asm shows that most of them could be replaced with
a simple

  #include <asm-generic/param.h>

as is done by, for example, the microblaze param.h file.  the only
noticeable difference in those files is the value of EXEC_PAGESIZE,
which is already conditionally set in the generic version:

  #ifndef EXEC_PAGESIZE
  #define EXEC_PAGESIZE   4096
  #endif

so, at worst, a param.h file could be replaced by:

  #define EXEC_PAGESIZE <whatever>
  #include <asm-generic/param.h>

rather than duplicating the same content over and over.  (i did this
sort of centralization once upon a time with the ioctl.h file.)

  worth doing?  not worth doing?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

             reply	other threads:[~2009-12-29 17:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 17:30 Robert P. J. Day [this message]
2009-12-29 18:09 ` simplify numerous param.h's by including <asm-generic/param.h>? Valdis.Kletnieks
2009-12-30  8:17   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0912291224520.2860@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox