Re: [Bug #15124] PCI host bridge windows ignored (works with pci=use_crs)

Yinghai Lu
2010-01-28T18:16:28Z

On 01/28/2010 08:24 AM, Jesse Barnes wrote:
> On Wed, 27 Jan 2010 22:02:26 -0600
> jeff@jgarrett.org (Jeff Garrett) wrote:
>
>> On Wed, Jan 27, 2010 at 07:24:09PM -0800, Jesse Barnes wrote:
>>> On Wed, 27 Jan 2010 17:50:17 -0800 (PST)
>>> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>>>> On Tue, 26 Jan 2010, Yinghai Lu wrote:
>>>>>
>>>>> [PATCH] x86/pci: don't use ioh resource if only have one ioh
>>>>
>>>> Please, no.
>>>>
>>>> This patch is too ugly to live.
>>>>
>>>> And it's totally unacceptable to probe every single possible PCI device
>>>> for something like this.
>>>>
>>>> If we don't know enough about the hardware workings of those Intel bridges
>>>> to know when they are active and how they decode things, then please let's
>>>> just disable intel_bus.c entirely.
>>>>
>>>> There's no excuse for hacky tests like this.
>>>
>>> Ok, we'll just kill it entirely then. I'll send a patch tomorrow
>>> unless Yinghai beats me to it.
>>
>> What about something like this (works for me, without pci=use_crs)?
>>
>> ---
>> Remove intel_bus.c Intel-specific PCI/IOH logic
>>
>> Signed-off-by: Jeff Garrett <jeff@jgarrett.org>
>
> Yeah, looks good. I'll push to Linus today.
>

please don't. will send you another patch, to keep the print out so we can cross check the _CRS.

YH