public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: don.mullis@gmail.com, david@fromorbit.com,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: modules, "modules" and CONFIG_LIST_SORT
Date: Sun, 7 Mar 2010 03:23:34 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1003070320370.4033@localhost.localdomain> (raw)
In-Reply-To: <20100307091223.GA4895@x200>



On Sun, 7 Mar 2010, Alexey Dobriyan wrote:
> 
> Unpleasant side effect of the change is that some modules stop being
> true modules, i. e. admin is unable to start using them without reboot
> if kernel was compiled without that tiny amount of core kernel.
> 
> Having used this feature several times, I think it'd be correct
> to preserve this behaviour, at least not regress for those modules
> which benefitted from it. For modules which were always "modules" (ipv6)
> it's fine to continue.
> 
> Can we declare some policy about it?
> 
> And revert LIST_SORT commit if yes.

Yeah, I think that in cases like this, you have a very good argument: 
LIST_SORT enables code that isn't that large, and is clearly very generic.

And changing the config later and trying to compile and install a module 
is rather sane. And if that new module needs LIST_SORT, you're screwed 
because it didn't get compiled in originally.

Honestly, personally I'd rather have a real library that modules can link 
to _before_ even loading into kernel space, but that's not how we've 
traditionally done things. So I guess we should just revert that commit.

		Linus

  reply	other threads:[~2010-03-07 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-07  9:12 modules, "modules" and CONFIG_LIST_SORT Alexey Dobriyan
2010-03-07 11:23 ` Linus Torvalds [this message]
2010-03-07 16:37   ` Randy Dunlap
2010-03-07 18:12     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1003070320370.4033@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=don.mullis@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox