From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: still worth running kernel cleanup scripts after merge windows?
Date: Mon, 8 Mar 2010 08:07:39 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1003080801560.3620@localhost> (raw)
just curious if there's still value in running my kernel scanning
scripts after each merge window closes and posting results. there's
still a fair bit of inconsistency and mismatches in the Kconfig files.
as a single example, here's a snippet from the
drivers/message/fusion directory, identifying an apparently bad
reference to a non-existent CONFIG variable:
>>>>> FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16
drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256
drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:
$ grep -r FUSION_MAX drivers/message/fusion
drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE > 128
drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE > 256
drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
$
so is that a typo? should "FUSION_MAX_FC_SGE" really be just
"FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just
put the scripts up at my wiki and people can run their at their
leisure on whatever part of the source tree interests them.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
next reply other threads:[~2010-03-08 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 13:07 Robert P. J. Day [this message]
2010-03-08 23:17 ` still worth running kernel cleanup scripts after merge windows? Randy Dunlap
2010-03-09 11:20 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1003080801560.3620@localhost \
--to=rpjday@crashcourse.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox