* still worth running kernel cleanup scripts after merge windows?
@ 2010-03-08 13:07 Robert P. J. Day
2010-03-08 23:17 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2010-03-08 13:07 UTC (permalink / raw)
To: Linux Kernel Mailing List
just curious if there's still value in running my kernel scanning
scripts after each merge window closes and posting results. there's
still a fair bit of inconsistency and mismatches in the Kconfig files.
as a single example, here's a snippet from the
drivers/message/fusion directory, identifying an apparently bad
reference to a non-existent CONFIG variable:
>>>>> FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16
drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256
drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:
$ grep -r FUSION_MAX drivers/message/fusion
drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE > 128
drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE > 256
drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
$
so is that a typo? should "FUSION_MAX_FC_SGE" really be just
"FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just
put the scripts up at my wiki and people can run their at their
leisure on whatever part of the source tree interests them.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: still worth running kernel cleanup scripts after merge windows?
2010-03-08 13:07 still worth running kernel cleanup scripts after merge windows? Robert P. J. Day
@ 2010-03-08 23:17 ` Randy Dunlap
2010-03-09 11:20 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-03-08 23:17 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List
On 03/08/10 05:07, Robert P. J. Day wrote:
>
> just curious if there's still value in running my kernel scanning
> scripts after each merge window closes and posting results. there's
> still a fair bit of inconsistency and mismatches in the Kconfig files.
I say Yes.
> as a single example, here's a snippet from the
> drivers/message/fusion directory, identifying an apparently bad
> reference to a non-existent CONFIG variable:
>
>>>>>> FUSION_MAX_FC_SGE
> drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE
> drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16
> drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256
> drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
>
> but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:
>
> $ grep -r FUSION_MAX drivers/message/fusion
> drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
> drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
> drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE < 16
> drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE > 128
> drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH CONFIG_FUSION_MAX_SGE
> drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
> drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE < 16
> drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE > 256
> drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
> $
>
> so is that a typo? should "FUSION_MAX_FC_SGE" really be just
> "FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just
> put the scripts up at my wiki and people can run their at their
> leisure on whatever part of the source tree interests them.
Yes, please.
AFAIK, the fusion maintainer doesn't read lkml.
Please use MAINTAINERS:
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
M: Eric Moore <Eric.Moore@lsi.com>
M: support@lsi.com
L: DL-MPTFusionLinux@lsi.com
L: linux-scsi@vger.kernel.org
W: http://www.lsilogic.com/support
S: Supported
F: drivers/message/fusion/
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: still worth running kernel cleanup scripts after merge windows?
2010-03-08 23:17 ` Randy Dunlap
@ 2010-03-09 11:20 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2010-03-09 11:20 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux Kernel Mailing List
On Mon, 8 Mar 2010, Randy Dunlap wrote:
> On 03/08/10 05:07, Robert P. J. Day wrote:
> > as a single example, here's a snippet from the
> > drivers/message/fusion directory, identifying an apparently bad
> > reference to a non-existent CONFIG variable:
> >
> >>>>>> FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16
> > drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256
> > drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
> >
> > but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:
> >
> > $ grep -r FUSION_MAX drivers/message/fusion
> > drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE < 16
> > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE > 128
> > drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH CONFIG_FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE < 16
> > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE > 256
> > drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE
> > $
> >
> > so is that a typo? should "FUSION_MAX_FC_SGE" really be just
> > "FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just
> > put the scripts up at my wiki and people can run their at their
> > leisure on whatever part of the source tree interests them.
>
> Yes, please.
http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup_scripts
have fun. (only the first script is there at the moment, additional
scripts to appear shortly.)
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-09 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 13:07 still worth running kernel cleanup scripts after merge windows? Robert P. J. Day
2010-03-08 23:17 ` Randy Dunlap
2010-03-09 11:20 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox