From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722Ab0CILWm (ORCPT ); Tue, 9 Mar 2010 06:22:42 -0500 Received: from astoria.ccjclearline.com ([64.235.106.9]:53799 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658Ab0CILWk (ORCPT ); Tue, 9 Mar 2010 06:22:40 -0500 Date: Tue, 9 Mar 2010 06:20:58 -0500 (EST) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost To: Randy Dunlap cc: Linux Kernel Mailing List Subject: Re: still worth running kernel cleanup scripts after merge windows? In-Reply-To: <4B9585A7.908@xenotime.net> Message-ID: References: <4B9585A7.908@xenotime.net> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Mar 2010, Randy Dunlap wrote: > On 03/08/10 05:07, Robert P. J. Day wrote: > > as a single example, here's a snippet from the > > drivers/message/fusion directory, identifying an apparently bad > > reference to a non-existent CONFIG variable: > > > >>>>>> FUSION_MAX_FC_SGE > > drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE > > drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16 > > drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256 > > drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE > > > > but there is no such Kconfig variable FUSION_MAX_FC_SGE. however: > > > > $ grep -r FUSION_MAX drivers/message/fusion > > drivers/message/fusion/Kconfig:config FUSION_MAX_SGE > > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE > > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE < 16 > > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE > 128 > > drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH CONFIG_FUSION_MAX_SGE > > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE > > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE < 16 > > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE > 256 > > drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE > > $ > > > > so is that a typo? should "FUSION_MAX_FC_SGE" really be just > > "FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just > > put the scripts up at my wiki and people can run their at their > > leisure on whatever part of the source tree interests them. > > Yes, please. http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup_scripts have fun. (only the first script is there at the moment, additional scripts to appear shortly.) rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================