From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758547Ab0CNNd7 (ORCPT ); Sun, 14 Mar 2010 09:33:59 -0400 Received: from astoria.ccjclearline.com ([64.235.106.9]:35863 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756350Ab0CNNd5 (ORCPT ); Sun, 14 Mar 2010 09:33:57 -0400 Date: Sun, 14 Mar 2010 09:32:10 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost To: Linux Kernel Mailing List Subject: should new kfifo implementation really be exporting that much? Message-ID: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org just curious about how much is being exported from kfifo.c: $ grep EXPORT_SYMBOL kernel/kfifo.c EXPORT_SYMBOL(kfifo_init); EXPORT_SYMBOL(kfifo_alloc); EXPORT_SYMBOL(kfifo_free); EXPORT_SYMBOL(kfifo_skip); EXPORT_SYMBOL(__kfifo_in_n); EXPORT_SYMBOL(kfifo_in); EXPORT_SYMBOL(__kfifo_in_generic); EXPORT_SYMBOL(__kfifo_out_n); EXPORT_SYMBOL(kfifo_out); EXPORT_SYMBOL(kfifo_out_peek); EXPORT_SYMBOL(__kfifo_out_generic); EXPORT_SYMBOL(__kfifo_from_user_n); EXPORT_SYMBOL(kfifo_from_user); EXPORT_SYMBOL(__kfifo_from_user_generic); EXPORT_SYMBOL(__kfifo_to_user_n); EXPORT_SYMBOL(kfifo_to_user); EXPORT_SYMBOL(__kfifo_to_user_generic); EXPORT_SYMBOL(__kfifo_peek_generic); EXPORT_SYMBOL(__kfifo_skip_generic); $ there's a lot there that looks like it should be static, no? or is all of that *meant* to be part of the public kfifo API? rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================