* [PATCH] KFIFO: kfifo_is_{full,empty} should return bools, not ints.
@ 2010-03-14 14:46 Robert P. J. Day
0 siblings, 0 replies; only message in thread
From: Robert P. J. Day @ 2010-03-14 14:46 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: stefani
For consistency with other kfifo routines, return bool, not int.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h
index bc0fc79..d6af6df 100644
--- a/include/linux/kfifo.h
+++ b/include/linux/kfifo.h
@@ -172,7 +172,7 @@ static inline unsigned int kfifo_len(struct kfifo *fifo)
* kfifo_is_empty - returns true if the fifo is empty
* @fifo: the fifo to be used.
*/
-static inline __must_check int kfifo_is_empty(struct kfifo *fifo)
+static inline __must_check bool kfifo_is_empty(struct kfifo *fifo)
{
return fifo->in == fifo->out;
}
@@ -181,7 +181,7 @@ static inline __must_check int kfifo_is_empty(struct kfifo *fifo)
* kfifo_is_full - returns true if the fifo is full
* @fifo: the fifo to be used.
*/
-static inline __must_check int kfifo_is_full(struct kfifo *fifo)
+static inline __must_check bool kfifo_is_full(struct kfifo *fifo)
{
return kfifo_len(fifo) == kfifo_size(fifo);
}
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-14 14:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-14 14:46 [PATCH] KFIFO: kfifo_is_{full,empty} should return bools, not ints Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox