From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759522Ab0CNQu6 (ORCPT ); Sun, 14 Mar 2010 12:50:58 -0400 Received: from astoria.ccjclearline.com ([64.235.106.9]:50720 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759508Ab0CNQu5 (ORCPT ); Sun, 14 Mar 2010 12:50:57 -0400 Date: Sun, 14 Mar 2010 12:49:08 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost To: Tilman Schmidt cc: Linux Kernel Mailing List Subject: Re: should new kfifo implementation really be exporting that much? In-Reply-To: <4B9D10D1.1060602@phoenixsoftware.de> Message-ID: References: <4B9D10D1.1060602@phoenixsoftware.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 14 Mar 2010, Tilman Schmidt wrote: > Am 14.03.2010 15:57 schrieb Robert P. J. Day: > > as a short followup, kfifo.h strongly implies that a lot of the > > above shouldn't be exported: > > > > ... > > /* > > * __kfifo_in_... internal functions for put date into the fifo > > * do not call it directly, use kfifo_in_rec() instead > > */ > > ... > > > > anyway, you get the idea. it would seem that a lot of those EXPORTs > > should be removed, no? > > If you look at kfifo_in_rec(), it's a static inline void function > defined in kfifo.h and which calls __kfifo_in_generic() or > __kfifo_in_rec(). I don't think you'll be able to make that work > without exporting those functions. huh. i believe you're correct. i'll take a closer look but i still get this feeling that there's something ... messy about that API. case in point: kfifo_in_rec() is *not* being exported, but a routine that it invokes -- __kfifo_in_generic() -- *is* being exported. doesn't that just seem a bit backwards? anyway, off to the gym to bike and see which duke team shows up for georgia tech. rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================