* is there any chance of cleaning up the "inline" chaos?
@ 2010-04-18 20:06 Robert P. J. Day
2010-04-18 20:41 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2010-04-18 20:06 UTC (permalink / raw)
To: Linux Kernel Mailing List
i mean, how many different definitions of inline are necessary?
#if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
!defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4)
# define inline inline __attribute__((always_inline))
# define __inline__ __inline__ __attribute__((always_inline))
# define __inline __inline __attribute__((always_inline))
#endif
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: is there any chance of cleaning up the "inline" chaos?
2010-04-18 20:06 is there any chance of cleaning up the "inline" chaos? Robert P. J. Day
@ 2010-04-18 20:41 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2010-04-18 20:41 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List
On Sun, 2010-04-18 at 16:06 -0400, Robert P. J. Day wrote:
> i mean, how many different definitions of inline are necessary?
>
> #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
> !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4)
> # define inline inline __attribute__((always_inline))
> # define __inline__ __inline__ __attribute__((always_inline))
> # define __inline __inline __attribute__((always_inline))
> #endif
Heave to, have at it.
$ git grep -w "inline" * | wc -l
35526
$ git grep -w "__inline__" * | wc -l
872
$ git grep -w "__inline" * | wc -l
17
It looks like __inline is almost exclusively in staging
and should be easy to fix/change
__inline__ is spread around all over the place
$ git grep -wl __inline__ * | wc -l
265
It could be converted over time or in a single sweep
like the recent slab changes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-18 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-18 20:06 is there any chance of cleaning up the "inline" chaos? Robert P. J. Day
2010-04-18 20:41 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox