From: Thomas Gleixner <tglx@linutronix.de>
To: Andres Salomon <dilinger@queued.net>
Cc: Ingo Molnar <mingo@elte.hu>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org, x86@kernel.org,
mingo@redhat.com, hpa@zytor.com, Mitch Bradley <wmb@laptop.org>,
linux-kernel@vger.kernel.org,
Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Subject: Re: [PATCH 2/2] x86: of: define irq functions to allow drivers/of/* to build on x86
Date: Tue, 21 Sep 2010 18:27:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1009211826240.2416@localhost6.localdomain6> (raw)
In-Reply-To: <20100921091136.45f5f7fa@debxo>
On Tue, 21 Sep 2010, Andres Salomon wrote:
> On Tue, 21 Sep 2010 11:45:37 +0200 (CEST)
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > > Any additional comments (ACKs, NACKs, etc) on the patches? If I
> > > need to rework it (or them), I can certainly make the patch
> > > description longer.
> >
> > Fine with me, but you could make the "mapping" function an inline as
> > well. While at it, some sensible changelog would be helpful :)
> >
> > Thanks,
> >
> > tglx
>
> Hm, inlining it would require some additional x86 #ifdefs in
> include/linux/of_irq.h (where the mapping function is declared). You'd
> prefer that?
Urgh, no.
tglx
next prev parent reply other threads:[~2010-09-21 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 13:01 [PATCH 2/2] x86: of: define irq functions to allow drivers/of/* to build on x86 Andres Salomon
2010-09-10 17:25 ` Grant Likely
2010-09-10 18:14 ` Ingo Molnar
2010-09-10 18:21 ` Grant Likely
2010-09-21 2:06 ` Andres Salomon
2010-09-21 2:32 ` H. Peter Anvin
2010-09-21 9:45 ` Thomas Gleixner
2010-09-21 16:11 ` Andres Salomon
2010-09-21 16:27 ` Thomas Gleixner [this message]
2010-09-21 19:27 ` Grant Likely
2010-09-21 9:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1009211826240.2416@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stephen.neuendorffer@xilinx.com \
--cc=wmb@laptop.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox