From: Linus Torvalds <torvalds@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jakub Jelinek <jakub@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix print out of function which called WARN_ON()
Date: Sun, 17 May 2009 15:54:35 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0905171552020.3301@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0905172335170.23616@blonde.anvils>
On Sun, 17 May 2009, Hugh Dickins wrote:
>
> No, not sure at all, that was just a conclusion I jumped to.
> Though I think I was seeing it on x86-32 too.
Ok, the 32-bit calling convention doesn't do any of that, even though we
compile the kernel with -mregparm=3. Any function with varargs arguments
gets all arguments passed on the stack, and we just pass the frame pointer
along, so there's no extra buffers.
So if you saw it on x86-32, then I think the only empty hole is indeed
due to that 'char function[KSYM_SYMBOL_LEN]' (and whatever stack alignment
code gcc does). And yes, it should be much better now.
Linus
next prev parent reply other threads:[~2009-05-17 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 16:17 [PATCH] Fix print out of function which called WARN_ON() Ian Campbell
2009-05-15 17:52 ` Linus Torvalds
2009-05-15 19:50 ` Andi Kleen
2009-05-16 20:47 ` Linus Torvalds
2009-05-17 14:43 ` Hugh Dickins
2009-05-17 22:18 ` Linus Torvalds
2009-05-17 22:24 ` David Miller
2009-05-17 22:47 ` Linus Torvalds
2009-05-17 22:45 ` Hugh Dickins
2009-05-17 22:54 ` Linus Torvalds [this message]
2009-05-18 9:09 ` Ian Campbell
2009-05-18 14:11 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0905171552020.3301@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hugh@veritas.com \
--cc=ian.campbell@citrix.com \
--cc=jakub@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox