linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Martin Knoblauch <spamtrap@knobisoft.de>
Cc: Matt Mackall <mpm@selenic.com>, Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c
Date: Tue, 19 May 2009 08:09:40 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0905190745230.3301@localhost.localdomain> (raw)
In-Reply-To: <231530.33013.qm@web32601.mail.mud.yahoo.com>



On Tue, 19 May 2009, Martin Knoblauch wrote:
> 
>  With your patch, the problem still remains. Line 1685 is the end of the patched routine now.

Ok, so can you do two other simple tests:

 - just remove the  "+ (long)&ret" entirely.

   Now, usually gcc doesn't have issues with non-asm things, but that's an 
   odd way of getting the current stack address by lookin gat the address 
   of a variable that hasn't even been used, so maybe it triggers some 
   untested codepath in gcc (and thus the bug).

 - if that doesn't make a difference, then remove the "get_cycles() +" 
   part instead.

   The fact that "arch/x86/include/asm/tsc.h:23" is mentioned in the insn 
   dump does make it look like get_cycles(), but on the other hand I'd 
   have actually expected it to be "arch/x86/include/asm/msr.h:112", 
   because that is the location of the actual asm statement. 

Just to see which part of it gcc has issues with.

		Linus

  reply	other threads:[~2009-05-19 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 13:29 Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c Martin Knoblauch
2009-05-18 20:34 ` Matt Mackall
2009-05-18 22:29   ` Linus Torvalds
2009-05-19  9:20     ` Martin Knoblauch
2009-05-19 15:09       ` Linus Torvalds [this message]
2009-05-19 17:52         ` Martin Knoblauch
2009-05-19 18:08           ` Linus Torvalds
2009-05-19 18:24             ` Linus Torvalds
2009-05-19 19:00               ` Martin Knoblauch
2009-05-20  7:53               ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2009-05-18 12:58 Martin Knoblauch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0905190745230.3301@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=spamtrap@knobisoft.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).