From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] IDE fixes
Date: Sun, 7 Jun 2009 16:57:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906071651250.6847@localhost.localdomain> (raw)
In-Reply-To: <200906080147.12274.bzolnier@gmail.com>
On Mon, 8 Jun 2009, Bartlomiej Zolnierkiewicz wrote:
>
> This is not a new feature and basing your opinions on opinions of people
> who don't read the code before commenting is bad, really bad, m'kay?
The thing is, I had planned on doing a final release yesterday, even
before your pull came in. I decided to hold off, let it be, just to test
the _current_ state a bit more. No way am I then adding some effectively
totally untested new code-path.
And if you start messing in partitions.c and adding whole new callback
functions to generic block_device_operations, then that's a new code-path.
The IDE subsystem has _no_ business adding random new callbacks in
the very last days of a release.
It sure as hell is not just a bugfix, it's a new feature. The feature may
be _needed_ for some specific bug report, but that is totally irrelevant.
We don't do things like that.
It's also almost certainly not a regression, is it? So by no measure does
it work as a "late in the -rc sequence" patch.
Linus
next prev parent reply other threads:[~2009-06-07 23:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 12:44 [git pull] IDE fixes Bartlomiej Zolnierkiewicz
2009-06-07 14:21 ` Alan Cox
2009-06-07 14:32 ` Bartlomiej Zolnierkiewicz
2009-06-07 14:40 ` Alan Cox
2009-06-07 15:03 ` Bartlomiej Zolnierkiewicz
2009-06-07 15:11 ` Alan Cox
2009-06-07 14:38 ` James Bottomley
2009-06-07 14:57 ` Bartlomiej Zolnierkiewicz
2009-06-07 15:18 ` James Bottomley
2009-06-07 15:44 ` Bartlomiej Zolnierkiewicz
2009-06-07 16:08 ` James Bottomley
2009-06-07 17:47 ` Bartlomiej Zolnierkiewicz
2009-06-07 19:08 ` James Bottomley
2009-06-07 19:23 ` Bartlomiej Zolnierkiewicz
2009-06-07 20:07 ` Alan Cox
2009-06-07 20:39 ` James Bottomley
2009-06-07 21:08 ` Bartlomiej Zolnierkiewicz
2009-06-07 20:42 ` Bartlomiej Zolnierkiewicz
2009-06-07 16:54 ` Pekka Enberg
2009-06-07 17:55 ` Bartlomiej Zolnierkiewicz
2009-06-07 18:21 ` Pekka Enberg
2009-06-07 19:00 ` Bartlomiej Zolnierkiewicz
2009-06-07 19:09 ` Pekka Enberg
2009-06-07 19:25 ` Bartlomiej Zolnierkiewicz
2009-06-07 23:15 ` Linus Torvalds
2009-06-07 23:47 ` Bartlomiej Zolnierkiewicz
2009-06-07 23:57 ` Linus Torvalds [this message]
2009-06-08 0:54 ` Bartlomiej Zolnierkiewicz
2009-06-07 23:14 ` Linus Torvalds
2009-06-07 23:12 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2009-05-22 15:17 Bartlomiej Zolnierkiewicz
2009-05-16 19:16 Bartlomiej Zolnierkiewicz
2009-05-16 19:22 ` Borislav Petkov
2009-05-16 19:33 ` Bartlomiej Zolnierkiewicz
2009-04-22 18:48 Bartlomiej Zolnierkiewicz
2009-04-22 19:06 ` Joe Perches
2009-04-22 19:22 ` Sam Ravnborg
2009-04-22 19:43 ` Bartlomiej Zolnierkiewicz
2009-04-22 19:55 ` Joe Perches
2009-04-22 21:41 ` Bartlomiej Zolnierkiewicz
2009-04-22 22:02 ` Ray Lee
2009-04-22 22:51 ` Bartlomiej Zolnierkiewicz
2009-04-22 22:58 ` Bartlomiej Zolnierkiewicz
2009-04-18 16:09 Bartlomiej Zolnierkiewicz
2009-03-13 20:49 Bartlomiej Zolnierkiewicz
2009-03-05 15:30 Bartlomiej Zolnierkiewicz
2009-03-05 16:27 ` Bartlomiej Zolnierkiewicz
2009-02-25 19:54 Bartlomiej Zolnierkiewicz
2009-02-02 19:48 Bartlomiej Zolnierkiewicz
2009-01-19 12:50 Bartlomiej Zolnierkiewicz
2008-12-22 22:08 Bartlomiej Zolnierkiewicz
2008-12-08 16:55 Bartlomiej Zolnierkiewicz
2008-10-05 16:38 Bartlomiej Zolnierkiewicz
2008-09-27 17:47 Bartlomiej Zolnierkiewicz
2008-09-10 20:47 Bartlomiej Zolnierkiewicz
2008-09-02 18:24 Bartlomiej Zolnierkiewicz
2008-08-18 20:22 Bartlomiej Zolnierkiewicz
2008-07-08 17:38 Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906071651250.6847@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox