From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Gary Hade <garyhade@us.ibm.com>, Matthew Wilcox <matthew@wil.cx>,
Larry Finger <Larry.Finger@lwfinger.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pci@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jaswinder Singh Rajput <jaswinder@kernel.org>
Subject: Re: [PATCH] x86/pci: don't use crs for root if we only have one root bus
Date: Wed, 24 Jun 2009 16:21:09 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906241615160.18460@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.01.0906241607100.18460@localhost.localdomain>
On Wed, 24 Jun 2009, Linus Torvalds wrote:
>
> I'm happy to apply various patches to fix it up, but regardless, I thinkwe
> should revert that commit as bogus. We can try making it the default again
> next round, when maybe it will be true that it doesn't cause issues.
Btw, I really think our _CRS handling sucks.
There's two things that you can do with _CRS:
- use the _existence_ of it as an indicator of a root bus
- try to use it to populate the resource tree.
And quite frankly, I think #2 is broken. There's no way in hell that ACPI
tables are ever going to be better than just asking the hardware. We've
gone through this before. Trusting ACPI over the hardware is just
FUNDAMENTALLY WRONG.
So I'm just going to do that revert. I'm not sure if it ever makes sense
to make that insane _CRS code the default. It seems like a fundamentally
flawed idea.
Linus
next prev parent reply other threads:[~2009-06-24 23:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090624122433.GA24781@elte.hu>
[not found] ` <20090624145119.GA12664@elte.hu>
2009-06-24 21:46 ` [PATCH] x86: fix _CRS resources return handling Yinghai Lu
2009-06-24 21:48 ` [PATCH] x86/pci: get root CRS before scan child -v2 Yinghai Lu
2009-06-24 22:37 ` Jesse Barnes
2009-06-25 0:03 ` Yinghai
2009-06-24 22:58 ` [PATCH] x86/pci: don't use crs for root if we only have one root bus Yinghai Lu
2009-06-24 23:09 ` Linus Torvalds
2009-06-24 23:21 ` Linus Torvalds [this message]
2009-06-24 23:37 ` Jesse Barnes
2009-06-24 23:54 ` Linus Torvalds
2009-06-25 0:01 ` Jesse Barnes
2009-06-25 7:03 ` Ingo Molnar
2009-06-25 7:28 ` Jaswinder Singh Rajput
2009-06-25 16:28 ` Jesse Barnes
2009-06-25 0:00 ` Gary Hade
2009-06-25 2:01 ` [PATCH 1/3] x86/pci: fix boundary checking when using root CRS Yinghai Lu
2009-06-25 2:02 ` [PATCH 2/3] x86/pci: get root CRS before scan childs -v3 Yinghai Lu
2009-06-25 3:00 ` [PATCH 2/3] x86/pci: get root CRS before scan childs -v4 Yinghai Lu
2009-06-30 1:16 ` [PATCH 1/3] x86/pci: fix boundary checking when using root CRS Jesse Barnes
2009-06-30 18:04 ` Gary Hade
2009-06-30 21:00 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906241615160.18460@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=garyhade@us.ibm.com \
--cc=jaswinder@kernel.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox