From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbZG0TlP (ORCPT ); Mon, 27 Jul 2009 15:41:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752649AbZG0TlO (ORCPT ); Mon, 27 Jul 2009 15:41:14 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33853 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbZG0TlO (ORCPT ); Mon, 27 Jul 2009 15:41:14 -0400 Date: Mon, 27 Jul 2009 12:40:11 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: OGAWA Hirofumi cc: "Aneesh Kumar K.V" , Alan Cox , "Rafael J. Wysocki" , Ray Lee , LKML , Andrew Morton Subject: Re: [PATCH] kdesu broken In-Reply-To: <87skgikjr8.fsf@devron.myhome.or.jp> Message-ID: References: <20090725163251.50e6f546@lxorguk.ukuu.org.uk> <87bpn7mzli.fsf@devron.myhome.or.jp> <20090727115723.1e8de60e@lxorguk.ukuu.org.uk> <873a8iqqgv.fsf@devron.myhome.or.jp> <20090727142303.41096bf5@lxorguk.ukuu.org.uk> <877hxujkuv.fsf@devron.myhome.or.jp> <20090727145805.690afe5d@lxorguk.ukuu.org.uk> <87fxci6ub9.fsf@devron.myhome.or.jp> <20090727161424.GA4233@skywalker> <20090727174252.2d987830@lxorguk.ukuu.org.uk> <20090727171213.GB4233@skywalker> <87skgikjr8.fsf@devron.myhome.or.jp> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jul 2009, OGAWA Hirofumi wrote: > > If I read that part of emacs correctly, it seems to be assuming the data > was already sent to master side if the child process was exited. That sounds like a rather obvious assumption. Aren't pty's flushing the data at flush() time? Which should be happening when the child process exits and closes the pty slave. So at what point do we just admit that the commit that caused all this was a buggy pile of sh*t and just revert it? Linus