Re: [Bug 13940] iwlagn and sky2 stopped working, ACPI-related

[Linus Torvalds <torvalds@linux-foundation.org>]

On Tue, 25 Aug 2009, Yinghai Lu wrote:
> 
> please try to attached patch, that will increae alignment from 32M to 64M.

Hmm. That may indeed fix the problem, because we have:

 - working-2.6.30.log:

	Allocating PCI resources starting at b8000000 (gap: b6000000:4a000000)

 - not-working-2.6.31.log:

	Allocating PCI resources starting at b6000000 (gap: b6000000:4a000000)

HOWEVER. We also have:

 - working-2.6.31_acpi=off.log:

	Allocating PCI resources starting at b6000000 (gap: b6000000:4a000000)

ie it really does seem to be ACPI-related somehow: starting PCI 
allocations at that b6000000 address works perfectly fine if ACPI is not 
enabled.

In the not-working version, we end up getting:

[    1.408588] pci 0000:00:1c.4: PCI bridge, secondary bus 0000:07
[    1.408593] pci 0000:00:1c.4:   IO window: 0x2000-0x2fff
[    1.408600] pci 0000:00:1c.4:   MEM window: 0xb6000000-0xb60fffff
[    1.408606] pci 0000:00:1c.4:   PREFETCH window: disabled
[    1.408623] pci 0000:00:1c.5: PCI bridge, secondary bus 0000:08
[    1.408626] pci 0000:00:1c.5:   IO window: disabled
[    1.408633] pci 0000:00:1c.5:   MEM window: 0xb6100000-0xb61fffff
[    1.408639] pci 0000:00:1c.5:   PREFETCH window: disabled


while in the working version we have:

 - ACPI off - looks like a BIOS allocated memory window:

	[    0.290854] pci 0000:00:1c.4: PCI bridge, secondary bus 0000:07
	[    0.290854] pci 0000:00:1c.4:   IO window: 0x3000-0x3fff
	[    0.290854] pci 0000:00:1c.4:   MEM window: 0xf4500000-0xf45fffff
	[    0.290854] pci 0000:00:1c.4:   PREFETCH window: disabled
	[    0.290854] pci 0000:00:1c.5: PCI bridge, secondary bus 0000:08
	[    0.290854] pci 0000:00:1c.5:   IO window: disabled
	[    0.290854] pci 0000:00:1c.5:   MEM window: 0xf4600000-0xf46fffff
	[    0.290854] pci 0000:00:1c.5:   PREFETCH window: disabled

 - ACPI on - we allocated the memory window, but at 0xb8000000+, rather 
   than directly after end-of-RAM:

	[    0.842970] pci 0000:00:1c.4: PCI bridge, secondary bus 0000:07
	[    0.842975] pci 0000:00:1c.4:   IO window: 0x2000-0x2fff
	[    0.842983] pci 0000:00:1c.4:   MEM window: 0xb8000000-0xb80fffff
	[    0.842989] pci 0000:00:1c.4:   PREFETCH window: disabled
	[    0.843012] pci 0000:00:1c.5: PCI bridge, secondary bus 0000:08
	[    0.843016] pci 0000:00:1c.5:   IO window: disabled
	[    0.843023] pci 0000:00:1c.5:   MEM window: 0xb8100000-0xb81fffff
	[    0.843029] pci 0000:00:1c.5:   PREFETCH window: disabled

ie for some reason ACPI caused that bus to be re-allocated, and 
re-allocating it right after the memory window doesn't work.

Crazy.

I wonder what is hiding at that 0xb6000000 address. And while I think that 
in this case rounding up to 64MB will fix it, I worry that our old model 
(of never starting directly after RAM, even if it was aligned) may not 
have been safer.

		Linus