The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Neil Horman <nhorman@tuxdriver.com>,
	linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Revert "kmod: fix race in usermodehelper code"
Date: Wed, 23 Sep 2009 16:43:09 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0909231642400.3303@localhost.localdomain> (raw)
In-Reply-To: <20090923230255.GA18878@Chamillionaire.breakpoint.cc>



On Thu, 24 Sep 2009, Sebastian Andrzej Siewior wrote:
> 
> The pach is wrong IMHO. UMH_WAIT_EXEC is called with VFORK what ensures
> that the child finishes prior returing back to the parent. No race. The patch
> makes it even worse because it does the thing it claims not do:
> - It calls ->complete() on UMH_WAIT_EXEC
> - the complete() callback may de-allocated subinfo

Yeah, I think you're right. That commit is bogus. Thanks for noticing.

		Linus

  reply	other threads:[~2009-09-23 23:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 23:02 [PATCH] Revert "kmod: fix race in usermodehelper code" Sebastian Andrzej Siewior
2009-09-23 23:43 ` Linus Torvalds [this message]
2009-09-24  0:15 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0909231642400.3303@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox