Re: [PATCH 19/19] workqueue: implement concurrency managed workqueue

Tejun Heo
2009-10-01T16:35:01Z

Andrew Morton wrote:
> On Thu, 1 Oct 2009 17:09:18 +0900 Tejun Heo <tj@kernel.org> wrote:
>
>> To solve the above issues, this patch implements concurrency-managed
>> workqueue.
>
> Seems reasonable.
>
> This approach would appear to rule out the option of setting a work
> thread's state (scheduling policy, scheduling priority, uid, etc) to
> anything other than some default.
>
> I guess that's unlikely to be a problem if we haven't yet had a need to
> do that, but I'd be a bit surprised to discover that nobody has done
> that sort of thing yet? Nobody has niced up their workqueue threads?

There were only two users in mainline which diddle with the worker
kthread. The stop machine call which uses RT priority and osl which
binds worker to cpu0. Both are updated not to do that in earlier
patches. For most cases, I don't think it would matter. For special
cases, given the rarity of them, I think we're better off with custom
kthread for now. If they become more prevalent, we'll need to add
support for it so that it can be done easier but even that turns out
to be the case I think it would better to implement that separately
from generic workqueue.

Thanks.

--
tejun