Re: [RFC PATCHSET] workqueue: implement concurrency managed workqueue

Jens Axboe
2009-10-01T09:05:31Z

On Thu, Oct 01 2009, Ingo Molnar wrote:
>
> * Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > On Thu, Oct 01 2009, Ingo Molnar wrote:
> > > My main worry is that in practice workqueues arent all that performance
> > > critical - so we are shooting to optimize something that doesnt
> > > necessarily use all the potential goodness inherent in this approach.
> >
> > Well, the main problem with the current code is that per-cpu
> > workqueues are way abused. I don't look at this patchset from a
> > performance point of view, but rather a way to limit this huge number
> > of idle and pointless threads. [...]
>
> I do look at it as a potentially (and primarily) big performance feature
> - if only it was utilized in a place where the performance aspect
> mattered.

That just makes it win-win-win :-)

> Sure, the memory savings are nice too.

As is the unified approach to async work handling, compared with what we
have now (which is several flavors of workqueues, async work, slow work,
etc).

--
Jens Axboe