Re: [PATCH, v2] kbuild: Improve version string logic

Frans Pop
2009-10-13T17:52:39Z

On Tuesday 13 October 2009, Ingo Molnar wrote:
> > IMO both LOCALVERSION_AUTO *and* the added "+" can be unsuitable for
> > some use cases, for example for distributions.
> >
> > If someone uses git to manage their custom patches, the only out this
> > patch leaves them to avoid the "+" is to revert it in their own trees.
>
> Is this a bad thing?

IMHO yes. This change essentially creates a backwards incompatibility with
existing naming schemes. Requiring to patch the change out to preserve an
existing naming scheme just seems a tad unfriendly.

But if I'm the only one who feels that way, go right ahead. You might
consider adding a comment in the Makefile as a pointer though.

I appreciate that you want this to be a strong default. Does Kconfig
support defining an option that can only be set by manually editing the
config and is not displayed as a config question?
If that is supported (or if support for that could be added), then that
might be a sufficiently obscure solution that experts would know how to
find, but would leave the vast majority of users using the default.

Cheers,
FJP