Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks

Paul Mundt
2010-06-08T06:34:53Z

On Mon, Jun 07, 2010 at 11:18:42PM -0700, David Rientjes wrote:
> On Tue, 8 Jun 2010, Boaz Harrosh wrote:
>
> > >> I already have my:
> > >> VERSION = 2
> > >> PATCHLEVEL = 6
> > >> SUBLEVEL = 35
> > >> -EXTRAVERSION = -rc2
> > >> +EXTRAVERSION = -rc2-my_tree
> > >>
> > >
> > > You shouldn't be using EXTRAVERSION for this purpose, you should be
> > > passing LOCALVERSION=my_tree to make.
> > >
> >
> > That will not work because the way I run make is out of my control. Every
> > one in the working group has his system. The Makefile is part of the
> > public git tree, so every one will get the same identification without
> > any confusion with Vanilla kernel, or what was compiled.
> >
>
> If everyone using that tree wants the same version string for that kernel,
> use CONFIG_LOCALVERSION="-my_tree" in your .config and use "make
> LOCALVERSION=".
>
Or just distribute a localversion-my_tree file in the top-level directory
like other trees do. This doesn't strike me as a particularly significant
problem.