Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks

David Rientjes
2010-06-08T09:17:29Z

On Tue, 8 Jun 2010, Boaz Harrosh wrote:

> And you have broken the "localversion* semantics". Because my vanilla release
> is 2.6.rc2-my_tree-my_ver as checkedout and delivered from my official tree.
> Now you have added a "+" regardless of if it is an official tagged version or
> not.
>

The `+' modifies the base kernel version, not the version string.
Otherwise, it would be impossible to determine whether a "2.6.35-rc2-foo"
kernel were vanilla 2.6.35-rc2 or otherwise modified.

> I do not expect a complicated "let me be smarter than you" system that
> checks any tags of mine and provides an out-of-tree version system. I just
> want a switch that tells the system. "Let me shoot myself in the leg,
> I know what I want"
>

If you're using git, which you obviously are, then add localversion* files
to your repository (or modify CONFIG_LOCALVERSION if you pass along your
.config as well) and use git-tag to indicate its something you're
releasing as your kernel.