Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks

David Rientjes
2010-06-08T06:18:53Z

On Tue, 8 Jun 2010, Boaz Harrosh wrote:

> >> I already have my:
> >> VERSION = 2
> >> PATCHLEVEL = 6
> >> SUBLEVEL = 35
> >> -EXTRAVERSION = -rc2
> >> +EXTRAVERSION = -rc2-my_tree
> >>
> >
> > You shouldn't be using EXTRAVERSION for this purpose, you should be
> > passing LOCALVERSION=my_tree to make.
> >
>
> That will not work because the way I run make is out of my control. Every
> one in the working group has his system. The Makefile is part of the
> public git tree, so every one will get the same identification without
> any confusion with Vanilla kernel, or what was compiled.
>

If everyone using that tree wants the same version string for that kernel,
use CONFIG_LOCALVERSION="-my_tree" in your .config and use "make
LOCALVERSION=".

> > Unless it's a vanilla 2.6.35-rc2 kernel, it's inaccurate to persent it as
> > 2.6.35-rc2; you'll need to pass LOCALVERSION to make to identify this as a
> > non-vanilla kernel.
>
> What are we lawyers? come on. And I do not have that problem! The output will
> not be 2.6.35-rc2 as you fear. It will be 2.6.35-rc2-my-tree-my-version.

That's because you're using EXTRAVERSION which is also used upstream to
describe kernel releases (stable, rc, mm, etc).

> Please stop this *none-sense* this is not your place to mandate my Kernel name. If
> I'm forced to have an external Makefile I can just "mv" what ever name I choose.
> The Kernel name is an ABI you have just broken that, You must revert it ASAP.
>

You still have the tools available to do everything you once did.